Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate over to enabledApiProposals #18184

Closed
brettcannon opened this issue Dec 14, 2021 · 0 comments · Fixed by #18269
Closed

Migrate over to enabledApiProposals #18184

brettcannon opened this issue Dec 14, 2021 · 0 comments · Fixed by #18269
Assignees
@karrtikr
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Milestone
January 2022

Comments

@brettcannon
Copy link
Member

brettcannon commented Dec 14, 2021 •
edited by karrtikr
Loading

This is being tracked in https://github.com/microsoft/vscode-internalbacklog/issues/2461.

This will require us to update our type definitions via @types/vscode (which we should make sure is in line with our engines definition for VS Code).

Will very likely need to specify at least "languageStatus" and "notebookConcatTextDocument".

Migration guide: microsoft/vscode#136964
@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-internal Label for non-user facing issues labels Dec 14, 2021
@kieferrm kieferrm mentioned this issue Dec 21, 2021
Closed
23 tasks
@karrtikr karrtikr mentioned this issue Jan 11, 2022
Merged
@karrtikr karrtikr added this to the January 2022 milestone Jan 11, 2022
@karthiknadig karthiknadig added the verified Verification succeeded label Jan 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

Successfully merging a pull request may close this issue.

Migrate over to using enabledApiProposals in package.json karrtikr/vscode-python
3 participants
@brettcannon @karthiknadig @karrtikr