Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not trigger test discovery if an invalid interpreter is selected for the workspace #19465

Closed
karrtikr opened this issue Jul 13, 2022 · 1 comment · Fixed by #19470
Closed

Do not trigger test discovery if an invalid interpreter is selected for the workspace #19465

karrtikr opened this issue Jul 13, 2022 · 1 comment · Fixed by #19470
Assignees
@karrtikr
Labels
area-testing feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2022

Comments

@karrtikr
Copy link

karrtikr commented Jul 13, 2022 •
edited
Loading

  • Identify whether it's an automatic or manual trigger.
  • Ensure we log this condition if it is automatically triggered, otherwise show the environment prompt.
  • On interpreter change, ensure discovery is triggered if interpreter is valid.
  • Ensure handler functions still get registered.
@karrtikr karrtikr added feature-request Request for new features or functionality needs PR area-testing labels Jul 13, 2022
@karrtikr karrtikr self-assigned this Jul 13, 2022
@karrtikr karrtikr mentioned this issue Jul 13, 2022
Closed
@karrtikr karrtikr changed the title Do not auto-trigger test discovery if an invalid interpreter is selected for the workspace Do not trigger test discovery if an invalid interpreter is selected for the workspace Jul 14, 2022
@karrtikr
Copy link
Author

karrtikr commented Jul 14, 2022 •
edited
Loading

Verification steps:

  • Interact with testing UI and any Python: ... related commands to testing and see if prompt shows up.

testentrypoint

@karrtikr karrtikr mentioned this issue Jul 14, 2022
Merged
@karrtikr karrtikr added this to the July 2022 milestone Jul 14, 2022
@karrtikr karrtikr added the verification-needed Verification of issue is requested label Jul 25, 2022
@amunger amunger added the verified Verification succeeded label Jul 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-testing feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2022
2 participants
@amunger @karrtikr