Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore ways to indicate to user whether Python is not installed or is invalid #19480

Closed
karrtikr opened this issue Jul 14, 2022 · 2 comments · Fixed by #19510
Closed

Explore ways to indicate to user whether Python is not installed or is invalid #19480

karrtikr opened this issue Jul 14, 2022 · 2 comments · Fixed by #19510
Assignees
@karrtikr
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs proposal Need to make some design decisions on-testplan Added to test plan
Milestone
July 2022

Comments

@karrtikr
Copy link

karrtikr commented Jul 14, 2022 •
edited
Loading

We need to let users know they need to select an interpreter, one way to let them know about this is if they use a feature manually. But seeing as manual triggers can be unnatural to run into and there aren't many, explore other ways.
@karrtikr karrtikr added feature-request Request for new features or functionality needs proposal Need to make some design decisions area-environments Features relating to handling interpreter environments labels Jul 14, 2022
@karrtikr karrtikr self-assigned this Jul 14, 2022
@karrtikr karrtikr mentioned this issue Jul 14, 2022
Closed
@karrtikr karrtikr added this to the July 2022 milestone Jul 18, 2022
@karrtikr karrtikr changed the title Explore utilizing problems window to indicate whether Python is not installed or is invalid, a quickfix to which leads to us opening the quickpick Explore ways indicate to user whether Python is not installed or is invalid Jul 19, 2022
@karrtikr
Copy link
Author

karrtikr commented Jul 20, 2022 •
edited
Loading

Spike results:

  • When utilizing problems window to indicate whether Python is not installed or is invalid and adding a quickfix to which leads to us opening the quickpick:

    problemswindow

    VSCode doesn't seem to support workspace level diagnostics at the minute, vscode.Diagnostic always needs a file. When we create a diagnostic for the workspace folder uri, it does not behave very nicely:

    • Clicking the problem opens a file which does not exist.
    • Unable to add workspace level quick fixes for the problem as the file doesn't exist.

    If we choose any of the opened python file randomly to display it:

    problemswindow2

  • When using status bar/language status items to indicate this situation:

Change the color of the status bar item to warning:

image

@karrtikr karrtikr changed the title Explore ways indicate to user whether Python is not installed or is invalid Explore ways to indicate to user whether Python is not installed or is invalid Jul 20, 2022
This was referenced Jul 20, 2022
Closed
Merged
@karrtikr
Copy link
Author

Verify the following warning appears in the status bar:
image

@karrtikr karrtikr added verification-needed Verification of issue is requested on-testplan Added to test plan and removed verification-needed Verification of issue is requested labels Jul 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs proposal Need to make some design decisions on-testplan Added to test plan
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Use status bar to indicate whether selected Python interpreter is invalid karrtikr/vscode-python
1 participant
@karrtikr