Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Installed package detection in pyproject.toml #21288

Closed
3 tasks done
karthiknadig opened this issue May 23, 2023 · 0 comments
Closed
3 tasks done

Test Installed package detection in pyproject.toml #21288

karthiknadig opened this issue May 23, 2023 · 0 comments
Labels
testplan-item Test plan item/assignments for upcoming release
Milestone

Comments

@karthiknadig
Copy link
Member

karthiknadig commented May 23, 2023

Refs: #21141

Complexity: 2

Create Issue


Requirements

  1. Python 3.7 or greater
  2. Latest python extension pre-release.

Verification steps:

  1. Ensure you have python and python extension installed.
  2. Make sure python extension is activated (open python file)
  3. Create pyproject.toml with following content:
[project]
name = "spam"
version = "2020.0.0"
description = "Lovely Spam! Wonderful Spam!"
keywords = ["egg", "bacon", "sausage", "tomatoes", "Lobster Thermidor"]
dependencies = [
    "httpx",
    "gidgethub[httpx]",
    "django; os_name != 'nt'",
    "django; os_name == 'nt'",
]

[build-system]
# Minimum requirements for the build system to execute.
requires = ["setuptools", "wheel"] # PEP 508 specifications.

Things to check:

  1. You should see hint squiggle like this, if the package is not installed. For os specific case you should see the squiggle only under the dependency that applies to your os. More environment markers here (https://peps.python.org/pep-0508/#environment-markers):
    image

  2. If you remove the [build-system] part and save, Create Environment button should go away.

  3. If there are no dependencies or if all packages are installed then Create Environment button should go away.

Note: we don't trigger on file system events to detect package installs at this point. So you will need to close and reopen the file for this.
Note 2: We don't validate versions at this point. We only detect if a package is installed.

@karthiknadig karthiknadig added the testplan-item Test plan item/assignments for upcoming release label May 23, 2023
@karthiknadig karthiknadig added this to the May 2023 milestone May 23, 2023
@Tyriar Tyriar changed the title Installed package detection in pyproject.toml Test Installed package detection in pyproject.toml May 30, 2023
@rebornix rebornix removed their assignment May 30, 2023
@gregvanl gregvanl removed their assignment May 31, 2023
@meganrogge meganrogge assigned meganrogge and unassigned Tyriar May 31, 2023
@meganrogge meganrogge removed their assignment May 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item Test plan item/assignments for upcoming release
Projects
None yet
Development

No branches or pull requests

5 participants