Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on VS Code proposed Code Action Auto Fix APIs #4028

Closed
mjbvz opened this issue Jan 17, 2019 · 1 comment
Closed

Feedback on VS Code proposed Code Action Auto Fix APIs #4028

mjbvz opened this issue Jan 17, 2019 · 1 comment

Comments

@mjbvz
Copy link

mjbvz commented Jan 17, 2019

Hi, I'm on the VS Code team. We are exploring extending VS Code's code actions to support automatic fixes and auto fix on save. You can find the two current proposal here

Your extension is a large user of code actions so we'd appreciate your feedback on these API proposals. Here are example use cases for these two areas:

  • For auto fix: I write the python 3 code print "hello world" and see red squiggle in the editor. I F8 to the error and then use a single keyboard shortcut to auto add the parens for the print expression print("hello world"). This fix has been marked as the preferred auto fix by your extension. Other alternative fixes could be provided in the existing lightbulb menu

  • For fix all: I forget I'm writing python and start adding semi colons at the end of every line. Thankfully, I've enabled "editor.codeActionsOnSave": { "source.autoFix": true } and your extension provides an autofix code action. This autofix action looks through the entire document and fixes all trivial errors (such as removing semicolons in safe places) in a single pass. So all I need to do is save the document and all the semicolons go away

This guide covers how to use VS Code's proposed APIs. Please let me know if you have any questions about these proposals, feedback on the API, or ideas for other auto-fix scenarios that you would like to see supported in VS Code

@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jan 17, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 17, 2019
@d3r3kk
Copy link

d3r3kk commented Jan 17, 2019

Closing, sending along to the MPSL team to review.

@d3r3kk d3r3kk closed this as completed Jan 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants