Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy failures are silenced. #5850

Closed
ericsnowcurrently opened this issue May 30, 2019 · 1 comment
Closed

Mypy failures are silenced. #5850

ericsnowcurrently opened this issue May 30, 2019 · 1 comment
Labels
area-linting bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on

Comments

@ericsnowcurrently
Copy link
Member

When mypy fails (e.g. when .py filename contains illegal characters) the extension acts as though nothing bad happened and as though the checked files are free of problems (even if there are some). It shouldn't be failing silently.

To reproduce:

  1. set the current workspace to use mypy
  2. add a file with an invalid filename
  3. add code that would cause mypy to report problems
  4. save it (triggering mypy to run
  5. check the "Problems" pane (no problems reported)

If you set "python.linting.mypyPath": "/bin/echo" then you'll see (in the Output pane) exactly how the extension invokes mypy. Invoking it manually using those args will show the failure output from mypy. That's what we should be showing normally rather than hiding it.

So here's what should probably be done:

  • write mypy error output to "Python" output pane
  • pop up a message saying that mypy failed
@karthiknadig
Copy link
Member

This should now be addressed in the new mypy extension: https://marketplace.visualstudio.com/items?itemName=ms-python.mypy-type-checker

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-linting bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants