Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conda run in the debug adapter #6010

Closed
DonJayamanne opened this issue Jun 13, 2019 · 8 comments
Closed

Use conda run in the debug adapter #6010

DonJayamanne opened this issue Jun 13, 2019 · 8 comments
Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

DonJayamanne commented Jun 13, 2019

Suggestion from Conda team

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-terminal triage-needed Needs assignment to the proper sub-team labels Jun 13, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 13, 2019
@DonJayamanne DonJayamanne removed the bug Issue identified by VS Code Team member as probable bug label Jun 13, 2019
@DonJayamanne DonJayamanne mentioned this issue Jun 13, 2019
24 tasks
@DonJayamanne DonJayamanne changed the title Use conda run ... to get environment variables Use conda run ... Jun 14, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Aug 14, 2019

conda run <env name> python <xyz.py>

The issue comes from spike #5664

@DonJayamanne DonJayamanne added this to the 2019 - August Sprint 16 milestone Aug 14, 2019
@karrtikr
Copy link

karrtikr commented Aug 28, 2019

Prescribed solution

questions:

@ericsnowcurrently
Copy link
Member

FYI, all other env types are fine because using the python executable directly is equivalent to activating first. Conda doesn't work like that and requires activation.

Also, keep in mind that the key objective of this issue is to resolve the race condition in env activation when we launch the debugger.

@DonJayamanne
Copy link
Author

Partial PR #6959

@DonJayamanne
Copy link
Author

communicate to the (old) debug adapter the path to conda
use "conda run" in the (old) debug adapter

With the new DA coming in as an experiment, do we need to consider adding support for conda run for the old debugger. I don't see much value in this.
Basically It's a lot of work, that'll be thrown away.

use "conda run" elsewhere in the extension? (only needed in cases where

Please see the PR mentioned earlier, changes to the factory class works would suffice (i.e. change one place, the factory class)

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Sep 16, 2019

For non-debugger cases, "conda run" makes failures consistent.

For the debugger case (a race condition) we will resolve this using the new debug adapter. See #7001.

@ericsnowcurrently
Copy link
Member

Affected components:

  • formatting
  • linting
  • testing
  • debugging
  • code execution

Solved by updating command provider.

@brettcannon brettcannon added the meta Issue that is tracking an overall project label Sep 16, 2019
@ericsnowcurrently ericsnowcurrently changed the title Use conda run ... Use conda run in the debug adapter Sep 25, 2019
@ghost ghost removed the needs PR label Sep 25, 2019
@ericsnowcurrently ericsnowcurrently changed the title Use conda run in the debug adapter Use conda run in the debug adapter Sep 25, 2019
@karthiknadig karthiknadig removed the meta Issue that is tracking an overall project label Sep 25, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Sep 25, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 25, 2019
@karthiknadig karthiknadig changed the title Use conda run in the debug adapter Spike: Use conda run in the debug adapter Sep 25, 2019
@ericsnowcurrently ericsnowcurrently self-assigned this Sep 30, 2019
@ericsnowcurrently ericsnowcurrently changed the title Spike: Use conda run in the debug adapter Use conda run in the debug adapter Sep 30, 2019
@ericsnowcurrently ericsnowcurrently removed their assignment Sep 30, 2019
@ericsnowcurrently
Copy link
Member

As noted earlier, we are going to leave the old debug adapter alone.

@ghost ghost removed the needs PR label Sep 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

6 participants