Run fish activation scripts with source instead of .

[brettcannon]

Welcome to fish, the friendly interactive shell
 (master *%) > source /Users/brettcannon/Repositories/python/voters/.venv/bin/activate.fish

That should have been:

. /Users/brettcannon/Repositories/python/voters/.venv/bin/activate.fish

(Note the . instead of source.)

[kimadeline]

getActivationCommandsForInterpreter() always calls source <activation file>:

vscode-python/src/client/common/terminal/environmentActivationProviders/bash.ts

Lines 25 to 31 in 7362b25

	public async getActivationCommandsForInterpreter(pythonPath: string, targetShell: TerminalShellType): Promise<string[] | undefined> {
	const scriptFile = await this.findScriptFile(pythonPath, this.getScriptsInOrderOfPreference(targetShell));
	if (!scriptFile) {
	return;
	}
	return [`source ${scriptFile.fileToCommandArgument()}`];
	}

[faho]

That should have been:

. /Users/brettcannon/Repositories/python/voters/.venv/bin/activate.fish

(Note the . instead of source.)

That can't be what's going on. In not-ancient fish, . is merely a compatibility function with source being a proper builtin. At best they do the exact same thing.

[brettcannon]

@faho huh, something funky happened on my shell instance that day then since . worked but source didn't.

[faho]

I recommend reverting #7387. It's useless complexity.

[brettcannon]

@faho any interest in submitting a PR to revert it?

[faho]

To be honest, no.

I don't use vscode and I've never had a python app where I had to use venv (mostly really tiny scripts and such), so I couldn't really test it. I could do the git bits, but that's just git revert 40a1d045f925bb1c3e7d7424e9d010297253cc78.

[DonJayamanne]

I introduced the change, hence fitting i revert it 😄

[karrtikr]

validated