Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve terminal activation experience #8907

Closed
luabud opened this issue Dec 4, 2019 · 1 comment
Closed

Improve terminal activation experience #8907

luabud opened this issue Dec 4, 2019 · 1 comment
Assignees
@luabud
Labels
area-terminal feature-request Request for new features or functionality needs proposal Need to make some design decisions

Comments

@luabud
Copy link
Member

luabud commented Dec 4, 2019 •
edited
Loading

as @ericsnowcurrently mentioned on #5330:

As already acknowledged above, the implementation in #7665 doesn't cover all the cases:

terminal is not ready or at a new prompt when the extension "types" the activation command (e.g. user is typing in the terminal or the terminal is running a command)
switch the activated Python env in the current [Python?] terminal when the user selects a different interpreter
...
[In the case of the first one, it is effectively a bug for which we have provided a workaround ("change the setting to false"), but it would be nice if we could find a way to make it work. I'm not sure the VS Code API gives us much opportunity though. We would need to know that the terminal is waiting at a new shell prompt. It would help if we had a shell-oriented API that let us introspect/inject on a per-prompt basis, but I'm not going to hold my breath. :) ]
@luabud luabud added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Dec 4, 2019
@luabud luabud changed the title Improve run in terminal experience Improve terminal activation experience Dec 4, 2019
@luabud luabud added area-terminal needs proposal Need to make some design decisions and removed triage-needed Needs assignment to the proper sub-team labels Dec 4, 2019
@luabud luabud mentioned this issue Dec 4, 2019
Closed
@luabud luabud self-assigned this Dec 4, 2019
@int19h int19h mentioned this issue Feb 13, 2020
Closed
@karthiknadig karthiknadig mentioned this issue Oct 10, 2020
Closed
This was referenced Apr 6, 2021
Closed
Closed
@luabud
Copy link
Member Author

luabud commented Dec 6, 2022

Closing in favour of #11039

@luabud luabud closed this as completed Dec 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luabud luabud

Labels
area-terminal feature-request Request for new features or functionality needs proposal Need to make some design decisions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luabud