Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support $schema property #925

Closed
sevillal opened this issue Feb 16, 2021 · 3 comments
Closed

Support $schema property #925

sevillal opened this issue Feb 16, 2021 · 3 comments
Assignees
@shsuman
Milestone
0.6.21 Release

Comments

@sevillal
Copy link
Contributor

sevillal commented Feb 16, 2021 •
edited
Loading

Support $schema property and enable dynamic schema registration for the files containing it.
@SiddhanthUnnithan
Copy link
Contributor

  • First we need to support the $schema property

  • What do we need to do to support this tag?

  • What is the best approach => start from scratch, build on top of what the RH team has already done, what happens after they add the support.

  • Start with commenting on their issue and ask about progress / merge plans.

  • Otherwise consider forking and publishing our own package.

@SiddhanthUnnithan SiddhanthUnnithan added this to the 0.6.21 Release milestone Feb 17, 2021
@shsuman
Copy link
Member

shsuman commented Feb 18, 2021

Following up with the RedHat team to know if they are gonna merge the PR.

redhat-developer/yaml-language-server#354

@shsuman
Copy link
Member

shsuman commented Mar 24, 2021 •
edited
Loading

Merged PR: https://msasg.visualstudio.com/OpenMind%20Studio/_git/OpenMindVSCode/pullrequest/2083544

and tracking conversation with RedHat in #960

@shsuman shsuman closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shsuman shsuman

Labels
None yet
Projects
None yet
Milestone
0.6.21 Release
Development

No branches or pull requests
3 participants
@SiddhanthUnnithan @shsuman @sevillal