vsce finding wrong files without --yarn option

[flimberger]

When packaging my extension, vsce failed with the following error message:

$ vsce package
This extension consists of 20743 separate files. For performance reasons, you should bundle your extension: https://aka.ms/vscode-bundle-extension. You should also exclude unnecessary files by adding them to your .vscodeignore: https://aka.ms/vscode-vscodeignore
 ERROR  invalid relative path: extension/../../../../lib/nodejs/lib/node_modules/generator-code/.azure-pipelines.yml

Running vsce reveals that it tries to pack up the whole global node_modules directory of my user:

$ vsce ls
../../../../lib/nodejs/lib/node_modules/generator-code/.azure-pipelines.yml
../../../../lib/nodejs/lib/node_modules/generator-code/generators/app/env.js
[... 20737 more lines ...]
../../../../lib/nodejs/lib/node_modules/yo/node_modules/wrap-ansi/node_modules/ansi-regex/package.json
../../../../lib/nodejs/lib/node_modules/yo/node_modules/wrap-ansi/node_modules/ansi-regex/readme.md

Adding the --yarn flag produces the expected behaviour and works in the current directory:

$ vsce ls --yarn
CHANGELOG.md
language-configuration.json
LICENSE
Makefile
package.json
README.md
syntaxes/blueprint.tmLanguage.json
$ vsce package --yarn
 DONE  Packaged: /home/flimberger/devel/plugins/vscode/android-system-tools/android-system-tools-0.0.2.vsix (9 files, 5.17KB)

My extension doesn't contain any code, therefore I expected the packaging progess to be agnostic to whether npm or yarn is used.

Platform: Ubuntu 18.04
Version: 1.66.0
Environment:

NPM_CONFIG_PREFIX="$HOME/lib/nodejs"
NPM_CONFIG_USERCONFIG="$HOME/lib/config/npmrc"
NODE_PATH="$NPM_CONFIG_PREFIX/lib/node_modules:/usr/lib/nodejs"
PATH="$NPM_CONFIG_PREFIX/bin:$PATH"

NPM configuration:

global=true

[joaomoreno]

My extension doesn't contain any code, therefore I expected the packaging progess to be agnostic to whether npm or yarn is used.

Does it have a package.json? Does it have any dependencies? Can you show me the sources of your extension?

[flimberger]

The extension is here, the package.json in question was mainly generated by yeoman, with some additional info by myself:

{
    "name": "android-system-tools",
    "displayName": "Android System Tools",
    "description": "Syntax support for file formats used in Android system development.",
    "version": "0.0.2",
    "publisher": "flimberger",
    "repository": {
        "type": "git",
        "url": "git+https://github.com/flimberger/android-system-tools.git"
    },
    "license": "BSD-2-Clause",
    "engines": {
        "vscode": "^1.36.0"
    },
    "categories": [
        "Programming Languages"
    ],
    "contributes": {
        "languages": [{
            "id": "blueprint",
            "aliases": ["Android Blueprint", "blueprint"],
            "extensions": [".bp"],
            "configuration": "./language-configuration.json"
        }],
        "grammars": [{
            "language": "blueprint",
            "scopeName": "source.bp",
            "path": "./syntaxes/blueprint.tmLanguage.json"
        }]
    }
}

[joaomoreno]

This packages just fine for me. Do you have more files in your local copy of that repository? Any symlinks?

[flimberger]

No symlinks in the repo, but I've moved the npm stuff with the NPM_CONFIG_PREFIX environment variable from the default locations. I will test without these redirections.

[justinfagnani]

I'm having the same problem in a monorepo that does have symlink to the sibling packages, but where I'm trying to ignore them by including node_modules in the .vscodeignore file. It seems like the node_modules isn't working, or the "invalid relative path" error is being emitted before ignoring files.

[joaomoreno]

@flimberger Is this still problematic?

[flimberger]

I have to check again, but in the meantime my platform migrated to Ubuntu 20.04. I will get back to you when I tested it.

[joaomoreno]

Sure, let me know.

[acccrop]

I also have the same problem. is there a solution to this?

[flimberger]

I cannot reproduce the issue anymore with vsce version 2.7.0 and node version v16.15.0 installed from snap on Ubuntu 20.04.

[flimberger]

That assessment was too soon, running vsce package asks if it should continue, since no license file can be found. If I continue, the package does not contain the extension directory. So unfortunately the issue is not fixed.

[redonkulus]

Was getting this same issue and --yarn worked for me until recently, I noticed using the --no-dependencies option avoided this issue as well.

[nagilson]

Experiencing the same issue because of npm links, might be related to #308