Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate any declared main/browser entrypoints are in the final vsix. #670

Closed
joerohde opened this issue Dec 20, 2021 · 1 comment · Fixed by #669
Closed

Validate any declared main/browser entrypoints are in the final vsix. #670

joerohde opened this issue Dec 20, 2021 · 1 comment · Fixed by #669
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality released
Milestone
January 2022

Comments

@joerohde
Copy link
Contributor

feat: sanity check to validate entrypoints#669

I managed to refactor my 'out' to 'dist', not noticing 'dist' was in my .vscodeignore. All that testing, but my poblished package had no entrypoints for a few hours.

Lame mistake - yeah. But with 2 potential entrypoints and the refactoring people will be doing to support the web context, I think it's possible others may miss one of their entrypoints. Regardless - it's a very easy sanity check and I've provided a potential PR.
@joerohde joerohde mentioned this issue Dec 20, 2021
Merged
@joaomoreno joaomoreno self-assigned this Dec 31, 2021
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Dec 31, 2021
@joaomoreno joaomoreno added this to the January 2022 milestone Dec 31, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality released
Projects
None yet
Milestone
January 2022
Development

Successfully merging a pull request may close this issue.

feat: sanity check to validate entrypoints
2 participants
@joaomoreno @joerohde