Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsce 2.23.0 incorrectly reports missing entrypoints #935

Closed
connor4312 opened this issue Feb 22, 2024 · 4 comments · Fixed by #936
Closed

vsce 2.23.0 incorrectly reports missing entrypoints #935

connor4312 opened this issue Feb 22, 2024 · 4 comments · Fixed by #936
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@connor4312
Copy link
Member

connor4312 commented Feb 22, 2024

[email protected] seems like it can no longer package remote tunnels (build pipeline)

npx @vscode/[email protected] package works, but npx @vscode/[email protected] package fails, stating:

 ERROR  Extension entrypoint(s) missing. Make sure these files exist and aren't ignored by '.vscodeignore':
  extension/dist/node/extension.js,
  extension/dist/web/extension.js

However, those files do exist and aren't ignored. vsce is being run within one package in an npm workspace. This can also be reproduced locally, though note that you need to authenticate with the devdiv npm feed to successfully npm install.

@connor4312 connor4312 changed the title vsce 2.23.0 says files that exist aren't found vsce 2.23.0 incorrectly reports missing entrypoints Feb 22, 2024
@joaomoreno
Copy link
Member

joaomoreno commented Feb 23, 2024

I'm really not sure how this was ever working before, since npm workspaces were never fully supported: #580

Also, it would be great to have good steps to repro this on a local machine. My best attempt got me to that error. But got me this error as well when I use 2.22.0:

 ERROR  invalid relative path: extension/../.ci/npm-publish.yml

@joaomoreno joaomoreno self-assigned this Feb 23, 2024
@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Feb 23, 2024
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Feb 23, 2024
@joaomoreno joaomoreno added this to the February 2024 milestone Feb 23, 2024
@joaomoreno
Copy link
Member

joaomoreno commented Feb 23, 2024

Ended up reverting the entire feature, which the original author doesn't even need any more.

Build passed: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=258857&view=results

Thanks for marking as verified. 🙏

@connor4312 connor4312 added the verified Verification succeeded label Feb 23, 2024
@connor4312
Copy link
Member Author

I'm really not sure how this was ever working before, since npm workspaces were never fully supported:

The extension bundles everything and runs with --no-dependencies, so nothing workspace-specific was ever needed

@joaomoreno
Copy link
Member

Ahhh I missed that. Good! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants