From 09bdfdeacada178d19a63c20559c4a3ab9739d6c Mon Sep 17 00:00:00 2001 From: Peng Lyu Date: Tue, 17 Jan 2023 16:41:29 -0800 Subject: [PATCH] Remove kernel picker source detail info. (#171561) * Re microsoft/vscode-jupyter#11904, remove detail from mru kernel picker source. * :lipstick: --- .../browser/viewParts/notebookKernelQuickPickStrategy.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelQuickPickStrategy.ts b/src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelQuickPickStrategy.ts index 7f83ba8ba672c..566b64a42ef5f 100644 --- a/src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelQuickPickStrategy.ts +++ b/src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelQuickPickStrategy.ts @@ -15,7 +15,6 @@ import { compareIgnoreCase, uppercaseFirstLetter } from 'vs/base/common/strings' import 'vs/css!./notebookKernelActionViewItem'; import { Command } from 'vs/editor/common/languages'; import { localize } from 'vs/nls'; -import { MenuItemAction } from 'vs/platform/actions/common/actions'; import { ICommandService } from 'vs/platform/commands/common/commands'; import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey'; import { ILabelService } from 'vs/platform/label/common/label'; @@ -796,13 +795,11 @@ export class KernelPickerMRUStrategy extends KernelPickerStrategyBase { if (group.length > 1) { quickPickItems.push({ label: source, - detail: localize('selectKernelFromExtensionDetail', "Kernels: {0}", group.map(kernel => kernel.label).join(', ')), kernels: group }); } else { quickPickItems.push({ label: group[0].label, - detail: source, kernel: group[0] }); } @@ -818,7 +815,6 @@ export class KernelPickerMRUStrategy extends KernelPickerStrategyBase { return { id: typeof action.command! === 'string' ? action.command! : action.command!.id, label: action.label, - detail: action.detail, description: action.description, command: action.command, documentation: action.documentation, @@ -830,8 +826,7 @@ export class KernelPickerMRUStrategy extends KernelPickerStrategyBase { const res: SourcePick = { action: sourceAction, picked: false, - label: sourceAction.action.label, - detail: (sourceAction.action as MenuItemAction)?.item?.source?.title + label: sourceAction.action.label }; quickPickItems.push(res);