Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] template string highlighting not working #1020

Closed
q42jaap opened this issue Dec 4, 2015 · 2 comments
Closed

[js] template string highlighting not working #1020

q42jaap opened this issue Dec 4, 2015 · 2 comments
Assignees
Labels
javascript JavaScript support issues
Milestone

Comments

@q42jaap
Copy link

q42jaap commented Dec 4, 2015

The template string highlighting is broken (it's announced to be working in 0.5.0: http://blogs.msdn.com/b/vscode/archive/2015/07/06/vs-code-es6.aspx).

My jsconfig.json file:

{
  "compilerOptions": {
    "target": "ES6",
    "module": "commonjs"
  }
}

backtick.js:

var x = null;
var y = `Hello ${x} World/*`
var z = null;

placed in the same directory and then open visual studio code with:
open .

using the following line in .bash_profile:

code () { VSCODE_CWD="$PWD" open -n -b "com.microsoft.VSCode" --args $* ;}

This results in the second line to be green (because of `/* which starts a block comment), also the last line is compeletely green as if it's a block comment...

If I add var sum = (var1, var2) => var1 + var2 as the first line in backtick.js, is highlighted correctly. If I remove jsconfig.json, it starts complaining. For me this is a check to see if the options jsonfig.json are correct and picked up by Code.

@egamma egamma added javascript JavaScript support issues bug Issue identified by VS Code Team member as probable bug labels Dec 4, 2015
@egamma egamma added this to the Dec 2015 milestone Dec 4, 2015
@egamma
Copy link
Member

egamma commented Dec 4, 2015

Since the blog post we have changed the coloring to textmate grammar and in December we are now switching to the TypeScript grammar.

Assigning to @aeschli to verify whether this now working properly.

@aeschli
Copy link
Contributor

aeschli commented Dec 7, 2015

Verified that this got fixed by #133.

@aeschli aeschli closed this as completed Dec 7, 2015
@aeschli aeschli changed the title template string highlighting not working [js] template string highlighting not working Dec 7, 2015
@aeschli aeschli removed the bug Issue identified by VS Code Team member as probable bug label Dec 15, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues
Projects
None yet
Development

No branches or pull requests

3 participants