Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist character encoding of open files across restart #10444

Closed
bruceiv opened this issue Aug 11, 2016 · 1 comment
Closed

Persist character encoding of open files across restart #10444

bruceiv opened this issue Aug 11, 2016 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@bruceiv
Copy link

bruceiv commented Aug 11, 2016

  • VSCode Version: 1.4.0
  • OS Version: Ubuntu 12.04

Steps to Reproduce:

  1. Open a file.
  2. Re-open the file using a non-default encoding (e.g. Windows 1252).
  3. Close VS Code.
  4. Re-open VS Code; layout of editor, open files, etc. will be persisted, character encoding will not be.

Expected behaviour:
Once I have explicitly re-opened a file in a different encoding, that encoding should be persisted along with the other session state (note that I am not asking for encoding auto-detection here, just that I don't have to manually specify it for the same open file every time I restart VS Code).

@bpasero bpasero added feature-request Request for new features or functionality file-explorer Explorer widget issues labels Aug 12, 2016
@bpasero bpasero added this to the Backlog milestone Aug 12, 2016
@bpasero bpasero removed their assignment Aug 17, 2016
@bpasero bpasero modified the milestones: January 2017, Backlog Dec 19, 2016
@bpasero bpasero self-assigned this Dec 19, 2016
@bpasero
Copy link
Member

bpasero commented Dec 19, 2016

  • To verify:
    Pushed a change to persist and restore encodings configured for any opened editor. Once an editor is closed and opened again the encoding will be picked again from the files.encoding setting. The only exception are when using UTF-8, UTF-16 LE and UTF-16 BE with a BOM where we can auto-detect the encoding.

@bpasero bpasero added the verification-needed Verification of issue is requested label Dec 19, 2016
@roblourens roblourens added the verified Verification succeeded label Jan 25, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants