Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insiders: exthost.log file already exists #108168

Closed
joaomoreno opened this issue Oct 6, 2020 · 2 comments
Closed

Insiders: exthost.log file already exists #108168

joaomoreno opened this issue Oct 6, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extension-host Extension host issues insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Just starting my Insiders gives me this:

image

@sandy081 Let me know if you need more info.

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extension-host Extension host issues log VS Code log issues labels Oct 8, 2020
@sandy081 sandy081 added this to the October 2020 milestone Oct 8, 2020
@sandy081
Copy link
Member

sandy081 commented Oct 8, 2020

Thats a great catch buddy, this is because I am not checking if file existence before creating it.

I also revealed another bug while investigating this - Web worker extension hosts across windows are using the same log file as I am not scoping it to window while creating. See the first entry exthost.log in the following picture - this is the single log file that all web worker extension hosts are logging to.

image

Also fixed this by pointing web worker ext host logs to a new folder webWorker under extHost{windowId}

image

@alexdima FYI

@sandy081
Copy link
Member

sandy081 commented Oct 8, 2020

To verify:

  • Enable web worker ext host using setting "extensions.webWorker": true
  • Restart VS Code
  • Open Developer tools console and make sure there are no errors like in description
  • Run command Open Extensions Log Folder and make sure web worker ext host log is in separate folder webWorker

@mjbvz mjbvz added the verified Verification succeeded label Oct 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extension-host Extension host issues insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@joaomoreno @sandy081 @mjbvz and others