Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: icons theming #111551

Closed
3 tasks done
aeschli opened this issue Nov 30, 2020 · 0 comments
Closed
3 tasks done

Test: icons theming #111551

aeschli opened this issue Nov 30, 2020 · 0 comments

Comments

@aeschli
Copy link
Contributor

aeschli commented Nov 30, 2020

Refs: #92791

Complexity: 3

Create Issue


  • clone the vscode-extension-samples and open the product-icon-theme-sample in VSCode

  • Look at theme/v1-product-icon-theme.json: the sample product icon theme redefines some of the view icons

  • press F5. The Extension Development Host window that opens should automatically have the new product icon theme enabled and show different view icons

  • make changes to the theme file, e.g. change run-view-icon.fontCharacter from \\e002 tp \\e001

  • the run view icon in the ext host window will change as you update the file (no reload needed)

  • use code completion in the theme file to look at more icons.
    Tester 1: debug icons, e.g debug-breakpoint
    Tester 2: extensions icons, e.g extensions-manage
    Tester 3: notebook icons, e.g notebook-execute
    ⚠️ notebookIcons have just been pushed, so need a new build from today

  • verify that all icons have descriptions in code assist and hover in the theme file. Test that the descriptions are understandable.

  • test that you can change some of the icons.
    (note that the font of the sample theme has only a limited number of glyphs (e000-e009, see product-icon-theme-sample/theme/vscode-10.html. The sample lets you add more icons, but that's not necessary to test)

Full list of icons can be found in
https://github.com/microsoft/vscode-docs/blob/vnext/api/references/icons-in-labels.md#L16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants