Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to automatically close the task's terminal when the task is done #112230

Closed
maximedupre opened this issue Dec 10, 2020 · 7 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality tasks Task system issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@maximedupre
Copy link

  1. Debug with a pre launch task
  2. Task has successfully completed
  3. Task terminal window is closed/destroyed automatically

Something to the effect of:

    {
        "label": "npm: knex:migrate",
        "problemMatcher": [],
        "script": "knex:migrate",
        "type": "npm",
        "closeWhenDone": true
    },

Seems like none of the presentation options currently allow me to do this.

My intention is to cleanup task windows automatically and stop accumulating them for a more organized workflow.

@vscodebot
Copy link

vscodebot bot commented Dec 10, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@maximedupre
Copy link
Author

@vscode-triage-bot Not duplicates :D

@alexr00 alexr00 added feature-request Request for new features or functionality tasks Task system issues labels Dec 11, 2020
@alexr00 alexr00 added this to the Backlog Candidates milestone Dec 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2021
@alexr00 alexr00 reopened this Apr 21, 2021
@alexr00 alexr00 closed this as completed in 7a92985 May 4, 2021
@alexr00 alexr00 reopened this May 4, 2021
@alexr00
Copy link
Member

alexr00 commented May 14, 2021

Given the current language we have when a task is complete, close seems like the best name:
image

@alexr00 alexr00 closed this as completed May 17, 2021
@alexr00 alexr00 added the verification-needed Verification of issue is requested label May 31, 2021
@alexr00
Copy link
Member

alexr00 commented May 31, 2021

To verify:

  1. F5 in your clone of this repo.
  2. Verify that the terminal that runs the "Ensure Prelaunch Dependencies" task closes when the task is done.

@lramos15 lramos15 added the verified Verification succeeded label Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality tasks Task system issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@lramos15 @maximedupre @alexr00 and others