Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask the user whether a custom editor should be made the default #118063

Closed
Tyriar opened this issue Mar 3, 2021 · 3 comments
Closed

Ask the user whether a custom editor should be made the default #118063

Tyriar opened this issue Mar 3, 2021 · 3 comments
Assignees
Labels
custom-editors Custom editor API (webview based editors) feature-request Request for new features or functionality on-testplan
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2021

Was having a discussion with @kieferrm and we were thinking the extension should not say it should be the default, but rather indicate that it makes sense and would like to be the default. That way VS Code can ask the user when one of these default extensions is installed when opening a supported file whether it would like to be the default (eg. Luna Paint), but not for "secondary" custom editors where that doesn't make as much sense (eg. Hex Editor).

This will help if we recommend installing Luna Paint from the image viewer (#116120) as the default wouldn't be changed out from under the user.

@Tyriar Tyriar added the custom-editors Custom editor API (webview based editors) label Mar 3, 2021
@mjbvz mjbvz added the feature-request Request for new features or functionality label Mar 4, 2021
@mjbvz mjbvz added this to the Backlog milestone Mar 4, 2021
@lramos15
Copy link
Member

lramos15 commented Apr 1, 2021

I'm not sure how we would know this is your first time opening a specific file type after a specific custom editor is installed. I think the easier flow would be something like themes which when installed shows you the current theme and gives you the option to switch your default.

@Tyriar
Copy link
Member Author

Tyriar commented Apr 1, 2021

@lramos15 the extensions list a set of extensions where it would make sense to be a default for. We could just keep a map in the storage service of the response the user gave to the question? eg.

answers['lunaPaint'] = {
  ".ico": true,
  ".bmp": false
}

Whether we ask on file open or extension install should probably be brought to the UX sync.

@lramos15
Copy link
Member

Closing for now as I've added a notification to prompt the user when there are two conflicting defaults

@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
custom-editors Custom editor API (webview based editors) feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @lramos15 @mjbvz and others