Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust workspace dialog does not go away after the trusted folders setting is updated #122450

Closed
rebornix opened this issue Apr 27, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Milestone

Comments

@rebornix
Copy link
Member

Testing #122252

  • Open two workspaces A and B, trust A but not B
  • Workspace B then has a modal dialog
  • Add workspace B into trusted setting from workspace A
  • In workspace B, all components related to trust are updated, but the modal dialog is still there.
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug workspace-trust Trusted workspaces labels Apr 27, 2021
@sbatten sbatten added this to the May 2021 milestone Apr 27, 2021
@sbatten
Copy link
Member

sbatten commented May 4, 2021

After discussion, dialogs don't really have dismissal concept because it would be weird to have a dialog appear and flicker away. Also, most scenarios where this presents itself are artificial from a testing mindset. The mainstream scenario is after an update/restart, restoring multiple windows. To address this, I will only show the dialog once the window is focused. This means trust will be evaluated at focus time, not restart time and if you trust B before navigating to it, the dialog will not show.

@sbatten sbatten closed this as completed in c2a8d68 May 4, 2021
@connor4312 connor4312 added the verified Verification succeeded label Jun 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workspace-trust Trusted workspaces
Projects
None yet
Development

No branches or pull requests

5 participants
@rebornix @connor4312 @lszomoru @sbatten and others