Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for more flexible layout options when moving a group via drag and drop #130131

Closed
byehack opened this issue Aug 4, 2021 · 13 comments
Closed
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-editor-grid Grid layout issues in the editor area
Milestone

Comments

@byehack
Copy link

byehack commented Aug 4, 2021

as i commented in #49923 (comment).
first split to editor like this:

______________
|      |     |
|      |     |
|______|_____|

then try to add new editor to the bottom of those, like this:

______________
|      |     |
|      |     |
|______|_____|
|            |
|____________|
Rec.0021.mp4
@hediet
Copy link
Member

hediet commented Aug 5, 2021

Can you add more details to your feature request?

@hediet hediet added the feature-request Request for new features or functionality label Aug 5, 2021
@hediet hediet added this to the Backlog Candidates milestone Aug 5, 2021
@byehack
Copy link
Author

byehack commented Aug 5, 2021

Can you add more details to your feature request?

i don't know i should tag here as issue or feature request.
as i said we should able to group the editor like this:

______________
|      |     |
|    1 |  2  |
|______|_____|
|     3      |
|____________|

we can not do it now.

@hediet
Copy link
Member

hediet commented Aug 5, 2021

This layout is possible:

image

@ArturoDent
Copy link

Split down first, then split right gets you the configuration you want. The question is: should the order of the splits matter?

@byehack
Copy link
Author

byehack commented Aug 6, 2021

This layout is possible:

can u reach that layout after splited like below?
(without close the right or left side splited editor completely)
image

@hediet
Copy link
Member

hediet commented Aug 6, 2021

Now I understand. I think this feature request makes sense.

Please update your initial commit to describe the current situation and the improvement you would like to see.

@bpasero bpasero removed this from the Backlog Candidates milestone Aug 7, 2021
@bpasero bpasero added info-needed Issue requires more information from poster and removed feature-request Request for new features or functionality labels Aug 7, 2021
@bpasero
Copy link
Member

bpasero commented Aug 7, 2021

I think the issue is around the fact that split always operates in the active group and not outside that group, so when you split the right group down it will end up as 2 groups in that space and you will not see a editor group create from the primary group.

How would you expect this to work? If we were to change this behaviour you would have equal amount of people that complain that the current behaviour is not possible. I think the current behaviour is more intuitive though.

@byehack
Copy link
Author

byehack commented Aug 7, 2021

we can use seprate line.
when drag a tab on seprate line it will preview new set.
image

@bpasero
Copy link
Member

bpasero commented Aug 8, 2021

I am not entirely sure we can do that without loosing the ability to split within the group then:

recording

@hediet
Copy link
Member

hediet commented Aug 9, 2021

Visual Studio has a nice solution for this afaik: During the drag operation, they show drop locations for various areas. I think in this case, they would show a symbol like this:

image

If you drop the editor on it, it will create the requested layout.

Well it will probably show all these locations:

image

@bpasero bpasero changed the title Improve editor grouping. Allow for more flexible layout options when moving a group via drag and drop Aug 9, 2021
@bpasero bpasero added feature-request Request for new features or functionality workbench-editor-grid Grid layout issues in the editor area and removed info-needed Issue requires more information from poster labels Aug 9, 2021
@bpasero bpasero removed their assignment Aug 9, 2021
@bpasero
Copy link
Member

bpasero commented Aug 9, 2021

Yeah I like what VS allows you to do but find the UI a bit heavy. Fair feature request

//cc @joaomoreno

@bpasero bpasero added this to the Backlog milestone Aug 9, 2021
@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Dec 6, 2022
@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

No branches or pull requests

6 participants
@bpasero @hediet @byehack @ArturoDent @vscodenpa and others