-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugs] Issues in new json settings editor #131343
Comments
(Experimental duplicate detection) |
Not the GUI editor but rather the new text-based editor (the side-by-side raw json view):
That shows a side-by-side view of two json trees - defaults in the left view and my customizations in the right view. The issues mentioned above are evident in the left view. |
Got it. If I fold a region of code, it stays folded when I switch tabs and switch back. Maybe you are closing the editor? The comment about sort order is fair, it is indeed arbitrary. I would like to keep the "Commonly used" section since I think it makes the most common settings easier to discover. |
Folding: works for me too, now... Weird wasn't working before. Commonly used: I assumed it wasn't actually doing anything, didn't realize it was still operational. |
It's just a hardcoded list of popular settings. Maybe we can sort the groups in a better way though |
Environment
Does this issue occur when all extensions are disabled?: Yes
Bug 1: nodes do not maintain collapsed/expanded state
It is inconvenient spending time finding a setting, switching away to refer to something, then switch back and losing your place because all the nodes are once again expanded.
Bug 2: nodes are not sorted
It is inconvenient having nodes in random order - it's already hard to find settings. So for example, the
"files"
node should come before the"window"
node.Bug 3: first node is now redundant
The first node has no value anymore, and since it's not labelled as such, it gets confusing because there are double nodes for everything in that list, which show up in searches.
Justification for fixing these bugs
Those bugs have been around for a long time, but we managed. However now that the json settings editor was removed ([1], [2]), please at least meet us halfway and address them.
Without the advanced features of the old json settings editor, these bugs make the experience time consuming and frustrating.
The text was updated successfully, but these errors were encountered: