Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Assign a keyboard shortcut key to Focus Terminal Output #133876

Closed
jooyoungseo opened this issue Sep 27, 2021 · 5 comments
Closed
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality info-needed Issue requires more information from poster terminal Integrated terminal issues
Milestone

Comments

@jooyoungseo
Copy link

CC @isidorn

Currently, neither Focus Terminal Tabs View nor Toggle Terminal puts user focus in the terminal output area; the default landing point is terminal input so screen reader users have to manually press Shift+Tab key to find the terminal output area, which is inconvenient.

@isidorn
Copy link
Contributor

isidorn commented Sep 27, 2021

I think it makes sense to have a command "Focus Terminal Output". Though I would not put a keybinding to it by default. Users could add it if they would want.

Assigning to @Tyriar and @meganrogge as owners of the Terminal. Let me know what you think about this.

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality terminal Integrated terminal issues labels Sep 27, 2021
@meganrogge
Copy link
Contributor

I don't believe we currently have a way to know where the output begins. We have been talking about ways we might be able to make the terminal less of a "black box" in the future in #133084

@jooyoungseo
Copy link
Author

Regardless whether it is currently possible to detect the beginning line of terminal output, there should be a way to assign a new command "Focus Terminal Output" that puts user focus to the <div class = "xterm-accessibility"> area because that area is currently focusable via tab key. Although I assume that area is active only when accessibility mode is on, please consider adding this feature for screen reader users because screen reader users (including me) need a quick way to check terminal output. Currently, it is inconvenient for us to find this terminal output area.

@microsoft microsoft deleted a comment Sep 28, 2021
@isidorn isidorn modified the milestones: Backlog Candidates, Backlog Sep 28, 2021
@isidorn
Copy link
Contributor

isidorn commented Sep 28, 2021

Thanks @meganrogge
@jooyoungseo if I understood Megan correctly currently VS Code is not aware of the inner structure of the terminal, thus VS Code does not know what element should be focused.
We could also hear what @Tyriar thinks once he comes back from vacation.

@Tyriar
Copy link
Member

Tyriar commented Oct 8, 2021

I think there was a misunderstanding.

@jooyoungseo is this so you can use the screen reader to go through the output, as opposed to using navigation mode (ctrl+up/down?). If so, why can't you use navigation mode?

@isidorn isidorn removed their assignment Nov 10, 2021
@Tyriar Tyriar added the info-needed Issue requires more information from poster label Dec 13, 2022
@Tyriar Tyriar closed this as completed Dec 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality info-needed Issue requires more information from poster terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

5 participants
@isidorn @Tyriar @jooyoungseo @meganrogge and others