Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jupyter Notebook files to use 4.5 format #134834

Closed
MSeal opened this issue Feb 27, 2021 · 2 comments · Fixed by #134835
Closed

Upgrade Jupyter Notebook files to use 4.5 format #134834

MSeal opened this issue Feb 27, 2021 · 2 comments · Fixed by #134835
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders

Comments

@MSeal
Copy link

MSeal commented Feb 27, 2021

In testing some reported issues in papermill, I noticed that the VS Code python extension was still outputting version 4.2 notebooks. The current spec is at 4.5 and given the popularity of VSCode for notebook development I think it'd help with tooling and maintenance if specs were caught up to current versions. The spec for older 4.x formats was back-ported to account for some 4.4 features being saved in older versions, but I'd still recommend at a minimum moving to 4.4 and plan / update to 4.5's addition of cell_id.

Happy to help discuss any concerns or details around the spec / upgrade.

@joyceerhl
Copy link
Contributor

Appreciate you bringing this to our attention @MSeal, we'll discuss prioritization for migrating to 4.4/4.5 at our team's weekly triage 😊 Thank you!

@joyceerhl
Copy link
Contributor

@MSeal It seems like JupyterLab itself doesn't support 4.5 yet. Would upgrading, either to 4.4 or 4.5, cause compatibility issues for our users who then open a 4.4/4.5 notebook in older versions of Jupyter?

@greazer greazer assigned DonJayamanne and unassigned joyceerhl Aug 5, 2021
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Oct 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@MSeal @DonJayamanne @joyceerhl and others