ctrl + ` evaluates as ctrl + ё

[nikelborm]

Does this issue occur when all extensions are disabled?: Yes

Version: 1.62.0
Commit: b3318bc
Date: 2021-11-03T15:18:44.904Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.11.0-38-generic

vokoscreenNG-2021-11-06_01-20-50.mp4

Steps to Reproduce:

1. open vs code
2. switch to Russian keyboard layout
3. try to open the terminal by pressing ctrl + `

Bug:

ctrl + ` evaluates as ctrl + ё, while for example ctrl + n works fine

Expected behavior:

ctrl + ` opens the terminal on any keyboard layout

[nikelborm]

And not only this keyboard event is laggy. ctrl + / doesn't work as expected on the Russian keyboard layout. It interpreters as ctrl + .

[alexdima]

I have tried with 1.61.2 and 1.60.2 and this behavior did not change with 1.62.0.

[alexdima]

The root problem here is that we ship with a keybinding for view terminal bound by default to ctrl+`. But ` cannot be produced using the Russian keyboard layout. We therefore don't have a default keyboard shortcut for view terminal. Fundamentally this is a problem that is tracked in #1240 . We don't ship with default keybindings optimized for each keyboard layout, but optimized only for the US keyboard layout. But I will leave this issue open, maybe we can improve our heuristics and in case a character is missing, like ` in this case, use its US position on the keyboard as a fallback.

[nikelborm]

The root problem here is that we ship with a keybinding for view terminal bound by default to ctrl+`. But ` cannot be produced using the Russian keyboard layout. We therefore don't have a default keyboard shortcut for view terminal. Fundamentally this is a problem that is tracked in #1240 . We don't ship with default keybindings optimized for each keyboard layout, but optimized only for the US keyboard layout. But I will leave this issue open, maybe we can improve our heuristics and in case a character is missing, like ` in this case, use its US position on the keyboard as a fallback.

but it worked perfectly before. It broke after vs code update. Somehow, on the Russian keyboard layout, it worked before

[alexdima]

@nikelborm I have tried both with 1.61.2 and 1.60.2 and there is no change in behavior. Is it possible that you were using "keyboard.dispatch": "keyCode" before?

[nikelborm]

@nikelborm I have tried both with 1.61.2 and 1.60.2 and there is no change in behavior. Is it possible that you were using "keyboard.dispatch": "keyCode" before?

I don't know about this thing. Maybe I used an older version. I will search at which version it worked fine and say for you later.