Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell integration: Auto detect shell integration profile #139404

Closed
Tyriar opened this issue Dec 17, 2021 · 1 comment
Closed

Shell integration: Auto detect shell integration profile #139404

Tyriar opened this issue Dec 17, 2021 · 1 comment
Assignees
@Tyriar @meganrogge
Labels
plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Milestone
January 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 17, 2021

Parent issue #133084

Related: #139395

Basic idea is to add for example bash (integrated) for the default shell if it's detected as supporting shell integration and we can reliably launch via args or env.
@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc. labels Dec 17, 2021
@Tyriar Tyriar added this to the January 2022 milestone Dec 17, 2021
@Tyriar Tyriar mentioned this issue Dec 17, 2021
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jan 14, 2022

We decided against this idea, instead enabling automatic injection of shell integration args via a global toggle and optional profile options.

@Tyriar Tyriar closed this as completed Jan 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Milestone
January 2022
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge