Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell integration: Implement enhanced cwd detection and working directory history #139407

Closed
Tyriar opened this issue Dec 17, 2021 · 2 comments · Fixed by #140676
Closed

Shell integration: Implement enhanced cwd detection and working directory history #139407

Tyriar opened this issue Dec 17, 2021 · 2 comments · Fixed by #140676
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 17, 2021

Parent issue #133084

Currently cwd tracking is done on macOS and Linux by running lsof or checking procos respectively, these mechanisms can be disabled if we get the cwd from shell integration as it will come in faster and without the need for additional polling. We also want to maintain a list of recent working dirs to support the go to recent directory feature #139402

This new cwd should work for relative links and the splitCwd setting.

@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc. labels Dec 17, 2021
@Tyriar Tyriar added this to the January 2022 milestone Dec 17, 2021
@meganrogge
Copy link
Contributor

this is complete IMO and we should create a new issue for the relative links and splitCwd setting

@Tyriar
Copy link
Member Author

Tyriar commented Jan 13, 2022

Let's do this before we close this off:

  • Move to new capabilities system
  • Make sure splitCwd and links use the new cwd is it's available, otherwise the old method
  • Make sure cwd detection works for Windows if shell integration is enabled
  • Update setting docs to call out shell integration
  • Remove the shell integration enabled sequence

@Tyriar Tyriar removed their assignment Jan 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Tyriar @meganrogge and others