Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does changing the setting only affect new shells? #141470

Closed
rzhao271 opened this issue Jan 25, 2022 · 1 comment
Closed

Does changing the setting only affect new shells? #141470

rzhao271 opened this issue Jan 25, 2022 · 1 comment
Assignees
Labels
*as-designed Described behavior is as designed polish Cleanup and polish issue

Comments

@rzhao271
Copy link
Contributor

Testing #141339

I realized after turning off the enable shell integration setting that the pwsh tab I was on still had the feature enabled, but after creating a new pwsh tab, I realized it didn't have the feature. Maybe the setting description can clarify when the setting is read.

@rzhao271 rzhao271 added the polish Cleanup and polish issue label Jan 25, 2022
@Tyriar
Copy link
Member

Tyriar commented Jan 25, 2022

It's described already:

Shell integration works by injecting a script that is run when the shell is initialized

Don't want to reiterate it as the shell integration setting will likely grow a fair bit to explain more of what it does next iteration.

@Tyriar Tyriar closed this as completed Jan 25, 2022
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Jan 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants