Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test builtin notebook output renderer #143437

Closed
2 tasks done
rebornix opened this issue Feb 19, 2022 · 1 comment
Closed
2 tasks done

Test builtin notebook output renderer #143437

rebornix opened this issue Feb 19, 2022 · 1 comment

Comments

@rebornix
Copy link
Member

rebornix commented Feb 19, 2022

Refs: #142429

Complexity: 4

Create Issue


We moved following mimetypes into the builtin notebook renderer extension

"image/gif",
"image/png",
"image/jpeg",
"image/git",
"image/svg+xml",
"text/html",
"application/javascript",
"application/vnd.code.notebook.error",
"application/vnd.code.notebook.stdout",
"application/x.notebook.stdout",
"application/x.notebook.stream",
"application/vnd.code.notebook.stderr",
"application/x.notebook.stderr",
"text/plain"

To test the new renderer, yon can

You don't necessarily have to test all mimetypes but following features are good ones to validate

  • Find in Outputs work (e.g., find in output works for text output print(1)). Some guidance on how to test find in output Test notebook hybrid find widget #141346
  • Error output are colorized properly
    with Error
  • Large output won't block the UI
     for i in range(0, 10000):
       print(i)
@kimadeline
Copy link

@kimadeline kimadeline removed their assignment Feb 23, 2022
@karrtikr karrtikr removed their assignment Feb 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants