Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal command decorations: Phrasing is odd #143705

Closed
joaomoreno opened this issue Feb 23, 2022 · 1 comment
Closed

Terminal command decorations: Phrasing is odd #143705

joaomoreno opened this issue Feb 23, 2022 · 1 comment
Assignees
Labels
*as-designed Described behavior is as designed

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Feb 23, 2022

Testing #143433

image

How about Command executed just now and failed?

@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2022

We use this helper for this:

export function fromNow(date: number | Date, appendAgoLabel?: boolean, useFullTimeWords?: boolean): string {

It gives us "now", "x seconds ago", "y minutes ago", etc., special casing "now" would mean either bringing the 30 second magic number into terminal land or making the change globally which is a much bigger change I'm not comfortable doing. Since we use it the same as settings sync, about, auth, etc. I'm closing as designed.

fyi @misolori

@Tyriar Tyriar closed this as completed Feb 23, 2022
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Feb 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

3 participants