Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal command decorations: Same command repeated gets no decoration #143707

Closed
joaomoreno opened this issue Feb 23, 2022 · 4 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Testing #143433

  1. Enable terminal.integrated.shellIntegration.enabled
  2. Type a command, hit Enter
  3. Type the same command, hit Enter

🐛 Every repeated execution after the first gets no decoration

image

@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2022

@joaomoreno what shell was this using?

@Tyriar Tyriar added info-needed Issue requires more information from poster bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. labels Feb 23, 2022
@Tyriar Tyriar added this to the February 2022 milestone Feb 23, 2022
@joaomoreno
Copy link
Member Author

Bash, straight out of a fresh Ubuntu 18.04 installation.

@Tyriar Tyriar removed the info-needed Issue requires more information from poster label Feb 23, 2022
@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2022

This is happening because bash's history on Linux seems to behave differently and merge entries unlike on macOS.

bash v5.1.4 on wsl:

image

bash v5.1.8 on macOS:

Screen Shot 2022-02-23 at 8 40 14 am

@Tyriar
Copy link
Member

Tyriar commented Feb 23, 2022

I worked around the issue so it should be fixed, it will still fail when the exit code changes which should be a very rare occurrence. That's a more invasive change which we'll handle next month as the shell scripts are quite fragile and changes to the protocol need to be applied to the pwsh/zsh scripts as well.

@connor4312 connor4312 added the verified Verification succeeded label Feb 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @Tyriar @connor4312 @meganrogge and others