Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCO: black border under buttons #150778

Closed
bpasero opened this issue May 31, 2022 · 7 comments
Closed

WCO: black border under buttons #150778

bpasero opened this issue May 31, 2022 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded

Comments

@bpasero
Copy link
Member

bpasero commented May 31, 2022

I see a black border under the WCO only in light themes:

image

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug titlebar VS Code main title bar issues labels May 31, 2022
@sbatten sbatten added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels May 31, 2022
@sbatten sbatten added this to the Backlog milestone May 31, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Aug 11, 2022

I'm unable to reproduce the issue on the latest Insiders on Windows 10. Are you still able to?

@rzhao271 rzhao271 added the info-needed Issue requires more information from poster label Aug 11, 2022
@bpasero bpasero modified the milestones: Backlog, August 2022 Aug 12, 2022
@bpasero bpasero closed this as completed Aug 12, 2022
@bpasero
Copy link
Member Author

bpasero commented Aug 15, 2022

Weird, now seeing this again in my VM:

image

But I still cannot really reproduce on my new Surface Laptop...

@deepak1556
Copy link
Collaborator

Seems like an issue only when hw acceleration is disabled electron/electron#31025

I could repro on windows hardware when running with --disable-gpu

@deepak1556 deepak1556 reopened this Aug 15, 2022
@deepak1556 deepak1556 added upstream-issue-linked This is an upstream issue that has been reported upstream and removed info-needed Issue requires more information from poster labels Aug 15, 2022
@deepak1556 deepak1556 modified the milestones: August 2022, Backlog Aug 15, 2022
@bpasero
Copy link
Member Author

bpasero commented Aug 15, 2022

Nice!

@deepak1556 deepak1556 added gpu Issues concerning GPU related items confirmed Issue has been confirmed by VS Code Team member labels Aug 15, 2022
@bpasero
Copy link
Member Author

bpasero commented Aug 16, 2022

Actually I think I was also tricked by the fact that WCO was not enabled by default on Windows: 2857051

@Roundlay
Copy link

Roundlay commented Aug 24, 2022

Is this solely related to hardware acceleration?

I'm seeing the same black line under the window buttons in Code with GPU acceleration enabled, as well as in other Electron apps, namely Signal.

In Code's case, I see the black line under the window buttons in two situations:

  • When both window.commandCenter and window.experimental.windowControlsOverlay.enabled are set to true. In this case, the black line seems to disappear when Code is maximised or fullscreened.
  • When window.commandCenter is set to false but window.experimental.windowControlsOverlay.enabled is set to true. In this case, the black line seems to appear when Code is maximised.

The black line occasionally shows up only after extended use,

GPU acceleration was enabled when testing these parameters, but I am using 125% display scaling, which has been reported as a trigger by others.

Here's the same issue in Signal:

image

@rzhao271
Copy link
Contributor

rzhao271 commented Oct 6, 2022

The upstream issue has been fixed by electron/electron#35312.
VS Code has taken in this change, so actually, this issue has been resolved.

Verification steps:

  1. On Windows, enable WCO (enable the window.experimental.windowControlsOverlay.enabled setting), and set the screen display scale to 125%
  2. Use a light theme for VS Code
  3. Verify that under the minimize/restore/maximize buttons, there's no black border. Maximize and restore the window and verify there's no black border under those buttons in both cases.

@rzhao271 rzhao271 closed this as completed Oct 6, 2022
@rzhao271 rzhao271 modified the milestones: Backlog, October 2022 Oct 6, 2022
@rzhao271 rzhao271 added the upstream-issue-fixed The underlying upstream issue has been fixed label Oct 6, 2022
@rzhao271 rzhao271 modified the milestones: October 2022, September 2022 Oct 6, 2022
@sbatten sbatten added the verified Verification succeeded label Oct 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants