Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete doesn't honor full width period. #15177

Closed
fcharlie opened this issue Nov 8, 2016 · 6 comments
Closed

autocomplete doesn't honor full width period. #15177

fcharlie opened this issue Nov 8, 2016 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues suggest IntelliSense, Auto Complete verified Verification succeeded

Comments

@fcharlie
Copy link

fcharlie commented Nov 8, 2016

  • VSCode Version:1.7.1
  • OS Version: Windows 10 1607. x64

Steps to Reproduce:

Markdown automatically appear inappropriate, after pressing enter does not correctly wrap automatically in the other language is appropriate, but at the time of writing is not necessarily

1

@mjbvz mjbvz added the markdown Markdown support issues label Nov 14, 2016
@mjbvz
Copy link
Collaborator

mjbvz commented Nov 14, 2016

@fcharlie Thanks for the report. Can you please provide a sample markdown file and describe the with the expected behavior. From the issue, it is not clear to me if VSCode is showing the wrong set of completions or if the completion is incorrect after you select it.

Thanks.

@fcharlie
Copy link
Author

Your can download any file https://github.com/fcharlie/fcharlie.github.io/tree/master/_posts

Your can use IME input some content.

@mjbvz mjbvz self-assigned this Mar 24, 2017
@mjbvz mjbvz changed the title Markdown autocomplete error Markdown IME autocomplete error Apr 11, 2017
@rebornix
Copy link
Member

rebornix commented Apr 19, 2017

The root cause is our word separators don't include Chinese punctuation in full width (and any other languages with same concept).

A full width Chinese period is so apparently we don't take it as word separator. That's why 等等。就 is still being suggested.

It's not a markdown issue, it's a generic language issue.

@rebornix rebornix removed the markdown Markdown support issues label Apr 19, 2017
@rebornix rebornix assigned rebornix and unassigned kieferrm and mjbvz Apr 19, 2017
@rebornix rebornix added suggest IntelliSense, Auto Complete under-discussion Issue is under discussion for relevance, priority, approach labels Apr 19, 2017
@rebornix rebornix changed the title Markdown IME autocomplete error autocomplete doesn't honor full width period. Apr 19, 2017
@joaomoreno joaomoreno assigned jrieken and unassigned joaomoreno Apr 20, 2017
@jrieken
Copy link
Member

jrieken commented Apr 21, 2017

This is an issue with the standard word definition.

@alexdima
Copy link
Member

The markdown language can customize its word definition via language configuration.

@alexdima alexdima removed their assignment May 21, 2017
@jrieken jrieken assigned mjbvz and unassigned rebornix and jrieken May 22, 2017
@kieferrm kieferrm added the markdown Markdown support issues label Aug 8, 2017
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Nov 13, 2017
@mjbvz mjbvz added this to the On Deck milestone Sep 18, 2018
@mjbvz mjbvz modified the milestones: On Deck, December 2018 Dec 11, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 11, 2018

For testing, try auto complete at the end of this markdown:

## URLDownloadToFile
自 Internet Explorer 3.0 开始,Urlmon.dll 中开始提供 URLDownloadToFile,支持从远程服务器上下载文件到本地。
URLDownloadToFile 会先将文件下载到 IE 缓存目录,然后再复制到设置的输出目录,如果第二次下载,就省去了下载时间。
Urlmon 还提供了下载到缓存目录的函数 URLDownloadToCacheFile,正因为 URLDownloadToFile 先下载到缓存目录,
就会出现缓存问题,可以使用 Wininet 中的 DeleteUrlCacheEntry 删除缓存。 删除

The suggestions should not include

@mjbvz mjbvz closed this as completed in 100adeb Dec 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2019
@aeschli aeschli added the verified Verification succeeded label Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants