Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell Integration wrong exit code if run same command for multiple times #154343

Closed
FindDefinition opened this issue Jul 7, 2022 · 1 comment
Closed

Shell Integration wrong exit code if run same command for multiple times #154343

FindDefinition opened this issue Jul 7, 2022 · 1 comment
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@FindDefinition
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.68.1
  • OS Version: Ubuntu 20.04

Steps to Reproduce:

  1. enable shell integration in bash
  2. run python -c $'import random\nif (random.randint(0, 1000) % 2 == 0):\n raise NotImplementedError \n' for multiple times
    image

I believe this is caused by this line. bash history index won't be increased if we run same command.
@Tyriar
Copy link
Member

Tyriar commented Jul 7, 2022

Very observant 😅

This is tracked in #143766, I'll see if we can get this covered for v1.70

/duplicate

@Tyriar Tyriar closed this as completed Jul 7, 2022
@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 7, 2022
@Tyriar Tyriar mentioned this issue Jul 7, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tyriar @FindDefinition @vscodenpa