Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Status Updates Are Blocking #168453

Closed
hediet opened this issue Dec 8, 2022 · 2 comments
Closed

Git Status Updates Are Blocking #168453

hediet opened this issue Dec 8, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues perf verified Verification succeeded
Milestone

Comments

@hediet
Copy link
Member

hediet commented Dec 8, 2022

  • Enable Auto-Save
  • Create a git repo (using powershell):
git init

for ($i = 0; $i -lt 1000; $i++) {
$fileName = New-Guid
New-Item -ItemType File -Path $fileName
}
  • Open the scm view, notice 1k untracked files
  • Open a file and type

This causes the attached profile. Notice that every time the file is written to disk, the UI freezes for ~200ms. For more files this is even slower.

Profile-20221208T144120.zip

image

@lszomoru lszomoru added git GIT issues perf bug Issue identified by VS Code Team member as probable bug labels Dec 8, 2022
@joaomoreno joaomoreno added this to the January 2023 milestone Dec 21, 2022
@lszomoru lszomoru modified the milestones: January 2023, On Deck Jan 19, 2023
@lszomoru lszomoru modified the milestones: On Deck, April 2023, May 2023 Apr 19, 2023
@lszomoru
Copy link
Member

The Insiders (2023-04-25) contains some improvements to the Source Control changes list.
@hediet, could you please retest the scenario and let us know if you are still seeing such long blocking time slices.

@hediet hediet added the verified Verification succeeded label Apr 25, 2023
@hediet
Copy link
Member Author

hediet commented Apr 25, 2023

Profiling doesn't show a bottleneck anymore.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues perf verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants