Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rich quick pick #1795

Closed
4 of 5 tasks
jrieken opened this issue Jan 5, 2016 · 12 comments
Closed
4 of 5 tasks

rich quick pick #1795

jrieken opened this issue Jan 5, 2016 · 12 comments
Assignees
Labels
api feature-request Request for new features or functionality
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jan 5, 2016

There are needs for more complex quick pick and asking for input, like do something on focus, validate user input etc. There are:

@jrieken jrieken added feature-request Request for new features or functionality api labels Jan 5, 2016
@jrieken jrieken self-assigned this Jan 5, 2016
@jrieken jrieken added this to the Jan 2016 milestone Jan 5, 2016
@jrieken
Copy link
Member Author

jrieken commented Jan 5, 2016

Idea is to have in addition to showQuickPick and showInputBox something like createQuickPick():QuickPick which could return something like this:

interface QuickPick {
  show(): void;
  hide(): void;
  items: Item[]|Thenable<Item[]>
  message: string;
  onDidSelectItem: Event<Item>
  onDidFocusItem: Event<Item>
  onDidBlurItem: Event<Item>
  onDidChangeInput: Event<string>
}

@daviwil
Copy link
Contributor

daviwil commented Jan 5, 2016

Interesting! cc @dfinke

@dfinke
Copy link

dfinke commented Jan 5, 2016

Looks good. It'd be nice to be able to customize the dropdown too. The extension install does with readme and install icons.

@alefragnani
Copy link

Hi @jrieken . Is it already available in the Insider build?

I tried to use the Extension API Consumption #1881 and Proposal for separating the vscode tools from the vscode API #970 instructions, but it still result in the same API. Maybe I'm doing something wrong in my package.json?

Thanks in advance.

@daviwil
Copy link
Contributor

daviwil commented Feb 4, 2016

I just updated to the latest vscode.d.ts (using the new install script) and I don't see it either.

@alefragnani
Copy link

Hi @daviwil ,

It was an error in my package.json. I fixed and now the new API is available:

Update the engine:

    "engines": {
        "vscode": "0.10.7-insiders"
    },

Add the postinstall script

  "scripts": {
    "vscode:prepublish": "node ./node_modules/vscode/bin/compile",
    "compile": "node ./node_modules/vscode/bin/compile -watch -p ./",
    "postinstall": "node ./node_modules/vscode/bin/install"
  },

Update vscode in devDependencies

  "devDependencies": {
    "vscode": "~0.11.0",
    "typescript": "^1.6.2"
  }

And it is working perfectly, thanks @jrieken 😄

@bpasero
Copy link
Member

bpasero commented Feb 4, 2016

@daviwil
Copy link
Contributor

daviwil commented Feb 4, 2016

Cool! I didn't know there was an 0.10.7-insiders engine specifically. I think I didn't understand what I was looking for in the quick pick typings, the API suggestion that Johannes wrote in a comment before is what I was looking for :) I can see now that the typings are different between 0.10.6 and 0.10.7. All good now, thanks for the help!

@masaeedu
Copy link

masaeedu commented May 6, 2016

@jrieken Regarding the "update items based on input" story that got removed, is there an alternative for this? It would be useful to allow the user to enter some custom text if none of the options suffice.

@jrieken
Copy link
Member Author

jrieken commented May 6, 2016

We are tracking that in #426

@wclr
Copy link

wclr commented Nov 26, 2016

allowing to have splitter in the list would be useful.

@aefernandes
Copy link
Contributor

Just to confirm, are these rich quick pick features currently available? I want to create custom keybindings for the quick pick dropdown items and currently can't do something on focus.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

8 participants