Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description is not changing for terminals which are not interacted with #180851

Closed
Tracked by #20822
karrtikr opened this issue Apr 25, 2023 · 3 comments · Fixed by #180903
Closed
Tracked by #20822

Description is not changing for terminals which are not interacted with #180851

karrtikr opened this issue Apr 25, 2023 · 3 comments · Fixed by #180903
Assignees
@karrtikr
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. ux User experience issues verified Verification succeeded
Milestone
April 2023

Comments

@karrtikr
Copy link
Contributor

karrtikr commented Apr 25, 2023 •
edited
Loading

Testing microsoft/vscode-python#21102 #171108

Originally posted by @aiday-mar in microsoft/vscode-python#21102 (comment)

⚠️ signs only appears next to terminals which are dirty, as they require a relaunch to update the envs. The second has not been interacted with yet, so envs are updated without the need for relaunching it, but it seems that the description is not updated.

Screen.Recording.2023-04-25.at.11.40.15.mov
@karrtikr karrtikr self-assigned this Apr 25, 2023
@karrtikr karrtikr transferred this issue from microsoft/vscode-python Apr 25, 2023
@karrtikr karrtikr added this to the May 2023 milestone Apr 25, 2023
@karrtikr karrtikr added terminal Integrated terminal issues bug Issue identified by VS Code Team member as probable bug and removed triage-needed labels Apr 25, 2023
This was referenced Apr 25, 2023
Closed
Closed
@karrtikr
Copy link
Contributor Author

@meganrogge any idea what might be going on?

@karrtikr karrtikr mentioned this issue Apr 26, 2023
Merged
@karrtikr karrtikr modified the milestones: May 2023, April 2023 Apr 26, 2023
@meganrogge
Copy link
Contributor

We automatically accept the env changes in terminals which haven't been interacted with by design. That is why the description for the non-interacted with terminal appears the way it does vs the one that has been interacted with which requires relaunching

@karrtikr
Copy link
Contributor Author

We automatically accept the env changes in terminals which haven't been interacted with by design.

I understand that, although the bug here is that we should automatically accept the description changes in such terminals as well.

@karrtikr karrtikr added ux User experience issues terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. labels Apr 26, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 26, 2023
@amunger amunger added the verified Verification succeeded label Apr 27, 2023
@karrtikr karrtikr mentioned this issue May 10, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

Update terminal status even if it is already present microsoft/vscode
4 participants
@amunger @karrtikr @meganrogge @vscodenpa