Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: native context menu location #188709

Closed
3 tasks done
bpasero opened this issue Jul 24, 2023 · 0 comments
Closed
3 tasks done

Test: native context menu location #188709

bpasero opened this issue Jul 24, 2023 · 0 comments

Comments

@bpasero
Copy link
Member

bpasero commented Jul 24, 2023

Refs:

Complexity: 4

Create Issue


This test is for making sure native context menus are well positioned in those cases where we want them to appear where the mouse cursor is. Previously we used to compute the x and y location for the context menu but with a new experimental setting we hand this off to Electron for positioning.

Setup:

  • configure window.experimental.nativeContextMenuLocation to be true (you can change this setting back and forth later without restart to compare the difference if any)
  • Windows/Linux: configure window.titleBarStyle to be native (this enables native context menu)
  • Restart VS Code

Testing

  • right click in various components of the UI to trigger the context menu at the mouse cursor, for example
    • the editor
    • items of lists and trees
    • configurable UI elements such as status bar entries, actions or views
  • verify that the context menu appears close to the mouse cursor
    • ⚠️ most importantly, verify that the context menu does not open and close immediately when releasing the mouse having picked an item of the menu because the menu opened under the mouse (example video of the bug)
  • make sure to cover context menus that open to the top / bottom / left / right by clicking at corner locations within the workbench window
  • make sure to cover overflowing context menus by testing on a smaller window size
  • change the window zoom levels and briefly check that the context menu is still usable
  • change your screen resolution and/or display scaling and briefly check that the context menu is still usable
@bpasero bpasero added this to the July 2023 milestone Jul 24, 2023
@ghost ghost assigned Tyriar, hediet and karthiknadig Jul 25, 2023
@hediet hediet removed their assignment Jul 25, 2023
@Tyriar Tyriar removed their assignment Jul 25, 2023
@karthiknadig karthiknadig removed their assignment Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants