-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong text decoration locations on vscode 1.88.1 #210393
Comments
Can you give an example of how to reproduce? |
um... sorry, i don't understand.exactly you said.. what's mean reproduce... you mean how to reproduce text decorations..?
123.mp4
2024-04-17.9.27.11.movor code? private createWalkMotionDecorator = (
ranges: vscode.Range[],
editor: vscode.TextEditor,
junbaeLocation: Location['junbaeLocation'],
) => {
const timeLeft = this.expiredAt - new Date().getTime();
if (timeLeft <= 0) {
this.dispose();
return;
}
const decoration = vscode.window.createTextEditorDecorationType({
after: {
contentText: ``,
margin: '0.5em 0 0 0',
textDecoration: `none; ${objectToCssString({
width: '50px',
height: '50px',
'background-size': 'contain',
'background-repeat': 'no-repeat',
'background-image': `url("${motions[this.combo % motions.length]}")`,
position: 'absolute',
/**
* NOTE: Junbae go out of screen when horizontal scroll
* If you want to limit position of Junbae, use `%`
*/
right: '5vw',
...junbaeLocation,
'z-index': 1,
'pointer-events': 'none',
})}`,
},
rangeBehavior: vscode.DecorationRangeBehavior.ClosedClosed,
});
this.walkDecoration?.dispose();
this.walkDecoration = decoration;
editor.setDecorations(this.walkDecoration, ranges);
}; when |
@hediet Is there anything I can help you with? If you'd like, you can advise me on which code to look into, and I'll take a look at it! |
Can you create a minimal vscode extension that showcases this bug and post the code? That way I can try to reproduce the issue. |
is there any updates? or anything i can help? |
I want to know how is this issue going |
is this fixing? |
plz.. how is it going...? if you wnat to help i can help you..! i just want to know why this issue occurred and how to fix it.. |
Does this issue occur when all extensions are disabled?: Yes. It related all extensions that use textDecoration.
In vscode, when setting the textEditorDecoration position to absolute and moving its location, before version 1.88, it used to change within the document, but now it's an issue where it changes within the line.
I can't find change logs for this. is there any change?
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: