Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.wordSegmenterLocales configuration don't take effect in simpleWidget editors (like chat or SCM input Editor) #223920

Open
Ninglo opened this issue Jul 26, 2024 · 1 comment · May be fixed by #223921
Assignees
Labels
chat feature-request Request for new features or functionality scm General SCM compound issues
Milestone

Comments

@Ninglo
Copy link

Ninglo commented Jul 26, 2024

Does this issue occur when all extensions are disabled?: Yes

About VSCode:

Version: 1.91.1 (Universal)
Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729
Date: 2024-07-09T22:07:54.982Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 22.6.0

Background

Issue #50045 has been resolved by PR #203605. However, this PR ignored simpleWidget editors (like chat or SCM input Editor).

Steps to Reproduce:

  1. Config "editor.wordSegmenterLocales": ["zh-CN"], in settings.json
  2. Paste 测试测试测试测试测试测试 (or any other test string) into chat or SCM input editor
  3. Trigger cursorWordLeft or cursorWordRight (shortcut: Option + ArrowLeft or ArrowRight)
  4. editor.wordSegmenterLocales configuration don't take effect in these editors

Reason

The getSimpleEditorOptions function don't return wordSegmenterLocales property.

image

ScreenShot

bug.mov
@lszomoru
Copy link
Member

@roblourens assigning this one to you as you already started looking at the submitted PR.

@roblourens roblourens added feature-request Request for new features or functionality scm General SCM compound issues chat labels Jul 31, 2024
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Jul 31, 2024
@microsoft microsoft deleted a comment from vs-code-engineering bot Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat feature-request Request for new features or functionality scm General SCM compound issues
Projects
None yet
4 participants