Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing quickSuggestions values validation #23432

Closed
aeschli opened this issue Mar 28, 2017 · 4 comments
Closed

missing quickSuggestions values validation #23432

aeschli opened this issue Mar 28, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 28, 2017

Testing #23284

Add to your settings:

   "editor.quickSuggestions": {
        "other": true,
        "comments": "sds",
        "strings": true
    }

no error on the wrong value

@aeschli
Copy link
Contributor Author

aeschli commented Mar 28, 2017

The problem is in the settings schema. I will push the fix. FYI @jrieken

@aeschli aeschli changed the title add quickSuggestions values validation missing quickSuggestions values validation Mar 28, 2017
@aeschli aeschli added this to the March 2017 milestone Mar 28, 2017
@aeschli aeschli self-assigned this Mar 28, 2017
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete labels Mar 28, 2017
@ramya-rao-a
Copy link
Contributor

@aeschli just curious, can extensions add such validations to their settings whose type is "object" as well?

@aeschli
Copy link
Contributor Author

aeschli commented Mar 28, 2017

It's the same for extensions. When a setting is defined, this is done with JSON schema that describes the shape of the value.
What kind of validations are you looking for?

@ramya-rao-a
Copy link
Contributor

Just type validations. Tried it out. Works as you said. Thanks!

@jrieken jrieken added the verified Verification succeeded label Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants