Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Match whole word" - fewer matches using ripgrep search #23624

Closed
roblourens opened this issue Mar 29, 2017 · 2 comments
Closed

"Match whole word" - fewer matches using ripgrep search #23624

roblourens opened this issue Mar 29, 2017 · 2 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
April 2017

Comments

@roblourens
Copy link
Member

Implement this on vscode's end using the same logic as before:

#23534 (comment)
@roblourens roblourens added search Search widget and operation issues bug Issue identified by VS Code Team member as probable bug labels Mar 29, 2017
@roblourens roblourens added this to the April 2017 milestone Mar 29, 2017
@roblourens roblourens self-assigned this Mar 29, 2017
@BurntSushi
Copy link

This bug in ripgrep is also potentially relevant: BurntSushi/ripgrep#389

@aeschli
Copy link
Contributor

aeschli commented Mar 31, 2017

Especially this search still returns very different results from before. With the fix for #23534 even less than before:
'${1:': with ripgrep: 13 matches, without ripgrep: 235 matches

@aeschli aeschli mentioned this issue Mar 31, 2017
Closed
@roblourens roblourens mentioned this issue Apr 4, 2017
Closed
@roblourens roblourens mentioned this issue Apr 11, 2017
Closed
@roblourens roblourens mentioned this issue Apr 19, 2017
Closed
@mjbvz mjbvz added the verified Verification succeeded label Apr 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
4 participants
@roblourens @BurntSushi @aeschli @mjbvz