Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 'percentage' in 'withProgress' #25534

Closed
aeschli opened this issue Apr 27, 2017 · 5 comments
Closed

Clarify 'percentage' in 'withProgress' #25534

aeschli opened this issue Apr 27, 2017 · 5 comments
Assignees
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Apr 27, 2017

Testing #18066

When using vscode.window.withProgress you get a progress that lets you set message and percentage.
What wasn't clear to me, what is the value range of percentage: (0...100) or (0..1.) ?

I didn't see any indication of that percentage, the status bar just shows the spinning wheel.

@jrieken jrieken added this to the April 2017 milestone Apr 27, 2017
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2017
@jrieken
Copy link
Member

jrieken commented Apr 27, 2017

Yeah, idea is that it's a value [0,1[ but actually nothing is implemented yet. For now, only support indefinite progress. We might also remove percentage for now and only add it back once we have a UI representation for it... @aeschli Ideas?

@jrieken jrieken added the api label Apr 27, 2017
@aeschli
Copy link
Contributor Author

aeschli commented Apr 27, 2017

I'd say remove it for now as it can easily be added again

@jrieken
Copy link
Member

jrieken commented Apr 27, 2017

Makes sense.

@mjbvz mjbvz added the verified Verification succeeded label Apr 27, 2017
@indiejames
Copy link

Does this mean percentage progress with not be available in the upcoming release?

@jrieken
Copy link
Member

jrieken commented May 2, 2017

Yes

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants