Integrated Terminal links with mixed styles don't work

[stijnvanderlaan]

• VSCode Version:
  1.12.1
• OS Version:
  OS X El Capitan (10.11.5)

Steps to Reproduce:

1. Cmd+Click on link in terminal (src/tests/index.test.js:26:56)
2. No underline appears and clicking does nothing

It did work in previous version 1.11 (without line number).

[Tyriar]

Cannot reproduce:

Can you provide a screenshot of the text that isn't working? Also make sure that the path is relative to the folder opened in VS Code, not the current working directory of the terminal.

[stijnvanderlaan]

No link in the screenshot is clickable. I can't even click on absolute links.

[Tyriar]

@stijnvanderlaan hm, still can't repro 😕

Just to confirm, you're holding cmd right?

[stijnvanderlaan]

Yes, It does still work in the editor, only not in de terminal. Only URLs in terminal work.

[Tyriar]

@stijnvanderlaan that screenshot's from the terminal, it works with the :x:y annotation too.

Could you check the devtools console for errors? (Help > Toggle Developer Tools)

[stijnvanderlaan]

I think it got something to do with the coloring of the PASS in front of the test. I also cannot reproduce it when I console a simple string.

[stijnvanderlaan]

Nope thats not it. It's because the last part of the string is bold:

var colors = require('colors');
console.log("src" + "/index.test.js".bold)

[stijnvanderlaan]

@Tyriar Can you re-open this?
Also when the line/column number has a style it's not becoming a link:
var colors = require('colors');
console.log("src" + "/index.test.js" + "1:1".bold)

(no error in Developer Tools)

[Tyriar]

It's because the last part of the string is bold

Yes I think this is the issue. The underlying issue is related to this one: xtermjs/xterm.js#642 #24743

[Tyriar]

Upstream issue: xtermjs/xterm.js#654