-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emmet 2.0: every word is being expanded by emmet #30265
Comments
This seems similar to what I'm having over here.. does your emmet basically suggest any word, whether it's an emmet snippet or not to be used as a tag? It would seem more useful if it only showed an emmet suggestions when it corresponded with an existing emmet snippet. It's pretty annoying inserting a break into a paragraph, only to have the last word turned into a set of tags. |
@niichie I agree, it shouldn't "suggest" completions that aren't real tags. |
Agreed that this and #30277 even more is annoying. I initially let this be as people also wanted the case of Here is my proposal:
This way, we do not forcefully push the option of expanding |
So basically, if the word we typed is an emmet abbreviaton, it will be shown on the suggestion llist, for example: If it is not an emmet abbreviation, it will only be shown if So we will no longer be getting results such as This would be a perfect solution, as the current implementation either has me choosing between not having any emmet suggestions at all, or having everything I type be turned into a suggestion. |
Correct. Except Look at https://github.com/emmetio/snippets/blob/master/html.json for all the emmet snippets. |
This is actually a perfect solution, because in combination with the HTML5 Snippets plugin, you can get both the normal snippets like |
I believe so, but wont be sure until I actually make the change |
I'm going to append to this thread because it looks like the same issues around emmet, recently, emmet lorem, generates a "div" tag around it, this is annoying. |
That's different.
This will be covered in this current issue |
Am back from vacation and conferences, now to some bug fixes :) @smlombardi @niichie I have pushed a fix to skip emmet suggestions when text is not a known snippet or a form of abbreviation. The change will be out in Wednesday's Insiders (19th July) Do try it out and let me know how it goes. |
Note to verifier:
|
(4 theme extensions excluded)
Steps to Reproduce:
<div class="foo">
<div cl
. Intellisense offers a completion ofcl
via Emmet for some reason.<div <cl></cl>
which makes no sense.class
(or at least other attributes with "cl" if there was such a thing)?The text was updated successfully, but these errors were encountered: