Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Many new weird DLLs showing up with new electron #32548

Closed
bpasero opened this issue Aug 15, 2017 · 5 comments
Closed

Windows: Many new weird DLLs showing up with new electron #32548

bpasero opened this issue Aug 15, 2017 · 5 comments
Assignees
@Tyriar
Labels
*as-designed Described behavior is as designed upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
August 2017

Comments

@bpasero
Copy link
Member

bpasero commented Aug 15, 2017

It is not clear to me what those are. See left insiders and right our stable release:

image
@bpasero bpasero added electron-update important Issue identified as high-priority labels Aug 15, 2017
@jens1o
Copy link
Contributor

jens1o commented Aug 15, 2017

I also noticed that, it's quite annoying, because the setup process of the new insiders versions are even longer now...

@Tyriar
Copy link
Member

Tyriar commented Aug 17, 2017

Asked Electron: electron/electron#10291

@Tyriar Tyriar added this to the August 2017 milestone Aug 17, 2017
@roblourens
Copy link
Member

Is the install size larger, or is it just redistributed?

Some of these at least we weren't shipping before, like vcruntime140.dll - if that stays, I can probably get the ripgrep binary to find it, and we won't have to ship a statically linked rg.exe, to save some KB.

@Tyriar
Copy link
Member

Tyriar commented Aug 17, 2017 •
edited
Loading

The dlls make it about ~1.5mb larger I think (uncompressed).

@Tyriar
Copy link
Member

Tyriar commented Aug 18, 2017

It was an intentional decision to dynamically link the lib for the various reasons outlined in electron/electron#9443. Closing as not going to fix.

@Tyriar Tyriar closed this as completed Aug 18, 2017
@Tyriar Tyriar added *as-designed Described behavior is as designed upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed important Issue identified as high-priority labels Aug 18, 2017
@roblourens roblourens mentioned this issue Aug 18, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*as-designed Described behavior is as designed upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
4 participants
@roblourens @bpasero @Tyriar @jens1o