Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal file path clickability when colour changes midway through file path #34195

Closed
johnnyreilly opened this issue Sep 12, 2017 · 3 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@johnnyreilly
Copy link

johnnyreilly commented Sep 12, 2017

  • VSCode Version: Code 1.16.0 (787b31c, 2017-09-06T16:27:49.891Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
vscode-eslint dba 1.3.0
githistory don 0.2.3
tslint eg2 1.0.3
csharp ms- 1.12.1
PowerShell ms- 1.4.2

Steps to Reproduce:

  1. Take the setup here: https://github.com/TypeStrong/ts-loader/tree/master/examples/fork-ts-checker
  2. npm install
  3. npm start
  4. Observe lack of clickability on errors:

screenshot 2017-09-12 06 12 25

The reason for this is the colour change that the fork-ts-checker-webpack-plugin produces between the path ("...fileWithError.ts") and the line number / column number ("(2:7)")

You can work around this by supplying a custom formatter to fork-ts-checker-webpack-plugin; see here: https://blog.johnnyreilly.com/2017/09/fork-ts-checker-webpack-plugin-code.html

However, I wonder if VS Code should be able to cope with these colour changes and preserve "clickability". What do you think?

@johnnyreilly johnnyreilly changed the title Terminal file path clickability Terminal file path clickability when colour changes midway through file path Sep 12, 2017
@johnnyreilly
Copy link
Author

See related PR for fork-ts-checker-webpack-plugin that works around this issue: TypeStrong/fork-ts-checker-webpack-plugin#48 (comment)

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2017

This limitation is fixed in Insiders (xtermjs/xterm.js#654), there are some lingering issues with links in Insiders though that should hopefully get fixed before it lands in stable.

@Tyriar Tyriar closed this as completed Sep 14, 2017
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 14, 2017
@johnnyreilly
Copy link
Author

Nice!

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants