Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Shared and Non-Shared Workspace Settings #39836

Closed
johnmcase opened this issue Dec 6, 2017 · 3 comments
Closed

Feature Request: Shared and Non-Shared Workspace Settings #39836

johnmcase opened this issue Dec 6, 2017 · 3 comments
Assignees
Labels
config VS Code configuration, set up issues info-needed Issue requires more information from poster

Comments

@johnmcase
Copy link

It would be nice if workspace level settings could be split into two separate .json files, one which is intended to be checked into source control and shared with the team, and one that is intended not to be shared and ignored from source control.

Use Case:
In my particular case, we are using the Perforce for VS Code plugin, which requires several settings to be set in order to find and login to the Perforce server. These settings obviously should not be shared across the team as everybody will have different values. I could theoretically store these settings in my user settings (or system environment variables), but those are global across all VS Code instances and unfortunately we have different server settings for different projects, so I would have to constantly go into my user settings and change them every time I switch projects.

At the same time there are definitely some settings that I want to share across all members of my team: typescript.tsdk for example, ensuring that every team member is using the typescript version that is pulled down from npm.

I know this use case is rather specific to my particular situation, but I have to believe that it is a fairly general and common scenario.

Suggestion:
Add the ability to create a settings.user.json file under the .vscode directory that is intended to be ignored in source control. In the case of conflict, the values set in settings.user.json would override the shared values in the settings.json file.

This is similar to Issue #851 however I don't see why the non-shared workspace settings need to be stored outside the workspace.

@vscodebot vscodebot bot added the workbench label Dec 6, 2017
@bpasero bpasero assigned sandy081 and unassigned bpasero Dec 7, 2017
@bpasero bpasero added config VS Code configuration, set up issues and removed workbench labels Dec 7, 2017
@sandy081
Copy link
Member

sandy081 commented Dec 7, 2017

@johnmcase

We have released a new Multi-root Workspace Feature where you can open multiple folders in a workspace. This introduces a new abstraction in settings.

User -> Workspace -> Folder

Settings under .vscode folder are called now Folder settings in a Multi-root workspace. You also have Workspace settings those get applied for complete workspace. For more information refer here.

You can open a folder in a workspace as follows and can use Workspace settings here as user specific workspace settings for the folder.

  • Open an empty window and add the folder to it.

Please try it out and let us know if that solves your issue

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Dec 7, 2017
@vscodebot vscodebot bot closed this as completed Dec 14, 2017
@vscodebot
Copy link

vscodebot bot commented Dec 14, 2017

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@johnemau
Copy link

I have the same request and @sandy081 the suggestion you provide does not work in the case were the team wants to have both a multi-root project and a combination of shared/private settings.

I would propose the following settings hierarchy
default settings -> global user settings -> shared multi-root settings -> user multi-root settings -> shared folder settings -> user folder settings (user folder settings trump all others)

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
config VS Code configuration, set up issues info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants