Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language support for Antler #41282

Closed
bgarrant opened this issue Jan 8, 2018 · 6 comments
Closed

Language support for Antler #41282

bgarrant opened this issue Jan 8, 2018 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality languages-basic Basic language support issues
Milestone

Comments

@bgarrant
Copy link

bgarrant commented Jan 8, 2018

I have had this same issue for a while now and wondering if there is a work around. When I use a custom language syntax like Antlers (https://marketplace.visualstudio.com/items?itemName=ahdesign.language-antlers) for example, the HTMl Autocomplete (Intellisense) no longer functions. If I associate antlers with html then I lose the antlers syntax coloring. How can I get both Antlers (or any other language) to work alongside the HTML Intellisense since the file has an .html extension?

I am using Latest VSC 1.19.1 on a 2017 MBP High Sierra

@vscodebot vscodebot bot added the html HTML support issues label Jan 8, 2018
@bgarrant
Copy link
Author

bgarrant commented Jan 8, 2018

This works in other editors such as Atom so can't figure out why VSC can get this to work? Wether I am using a Twig or Antlers extension, same issue. No HTML Autocomplete or Intellisense.

Type <div class and you will get nothing but text suggestions. and it does not even complete the <div class="">.

@bgarrant
Copy link
Author

bgarrant commented Jan 8, 2018

It all comes back to the mixed language issue. It seems VSC as no way to natively do this. Once I enable another language this is what I get for HTML autocomplete when typing <d. This is an .html file running with Antlers plugin mentioned above. All I get are text based suggestions

screen shot 2018-01-08 at 11 49 58 am

@bgarrant
Copy link
Author

bgarrant commented Jan 8, 2018

When in plain HTML mode on same file I lose the Antlers syntax coloring but I get this when typing same <d. This is how it should work.

screen shot 2018-01-08 at 11 55 20 am

@bgarrant
Copy link
Author

Is there any way to use two languages together?

@aeschli aeschli changed the title HTML Intellisense inside other Languages Code completion for Antler Jan 11, 2018
@aeschli aeschli removed the html HTML support issues label Jan 11, 2018
@aeschli
Copy link
Contributor

aeschli commented Jan 11, 2018

The clean way is if there's an Antler extension that implements a proper Antler language server, or forwards all requests to HTML (if Antler really compatible with HTML)

@aeschli aeschli added this to the Backlog milestone Jan 11, 2018
@aeschli aeschli added the feature-request Request for new features or functionality label Jan 11, 2018
@aeschli aeschli changed the title Code completion for Antler Language support for Antler Jan 11, 2018
@aeschli aeschli added the languages-basic Basic language support issues label Jan 11, 2018
@aeschli
Copy link
Contributor

aeschli commented Oct 8, 2019

Proper Antler support should come from a Antler language server. See #47288 on why this is the best solution.

We have #49210 to think about how a simpler story to basic HTML support working in HTML template languages that don't have a language server.

@aeschli aeschli closed this as completed Oct 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality languages-basic Basic language support issues
Projects
None yet
Development

No branches or pull requests

2 participants